Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MWPW-146743 - Fix get image caption #54

Merged
merged 4 commits into from
Jun 20, 2024
Merged

MWPW-146743 - Fix get image caption #54

merged 4 commits into from
Jun 20, 2024

Conversation

JasonHowellSlavin
Copy link
Contributor

  • Removes the return of "undefined" in getImageCaption. If caption is ever appended to the DOM without checking for it's value first, it will result in an "undefined" string getting added to the DOM.

Resolves: MWPW-146743

Test URLs:

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 19, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jun 19, 2024 •
edited
Loading

Page Scores Audits Google
/blog/basics/knowledge-areas?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@JasonHowellSlavin JasonHowellSlavin merged commit 20f6fef into stage Jun 20, 2024
4 checks passed
@JasonHowellSlavin JasonHowellSlavin deleted the fix-get-image-caption branch June 20, 2024 20:39
@JasonHowellSlavin JasonHowellSlavin mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meganthecoder meganthecoder meganthecoder approved these changes

@overmyheadandbody overmyheadandbody overmyheadandbody approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonHowellSlavin @overmyheadandbody @meganthecoder